Change sharedHistory flag to unstable variant
#1449
Merged
+447
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
requested review from
a team,
BillCarsonFr and
aringenbach
and removed request for
a team
aringenbach
approved these changes
Apr 29, 2022
Co-authored-by: aringenbach <[email protected]>
Yea in this case I wanted to write the integration tests consistently with the rest of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves element-hq/element-ios#4947 which is an implementation of matrix-org/matrix-spec-proposals#3061
Handle several edge cases when key sharing:
shared_historywhen exporting and importing keys. This makes it compatible with the existing web implementation (e.g. backup keys on the web and restore on iOS => preservesharedHistoryflag)